Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing @ApiResponse causes issues when trying to generate client #606

Open
Eneuman opened this issue Jul 1, 2024 · 1 comment
Open

Comments

@Eneuman
Copy link

Eneuman commented Jul 1, 2024

Hi

I'm trying to generate a API client using the swagger file that Snowstorm generates but its failing because the return types are not defined.

An example is the "Create a import job" in the /import API.
Since there is no @ApiResponse declared, swagger will create a default HTTP 200 result for all POST but this is wrong in this case.
The /import do return a HTTP 201 Created. This issue causes the generated code to be wrong :(

Any chance you could also add @ApiResponse to the code so the swagger file becomes even better :) ?

Docs: https://www.baeldung.com/swagger-operation-vs-apiresponse#apiresponse

@kaicode
Copy link
Member

kaicode commented Jul 7, 2024

We are happy to accept PRs for this enhancement request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants