Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2:104.4.1.3 - conditional update, but not really #72

Closed
lynnfel opened this issue Aug 5, 2021 · 7 comments
Closed

2:104.4.1.3 - conditional update, but not really #72

lynnfel opened this issue Aug 5, 2021 · 7 comments
Assignees

Comments

@lynnfel
Copy link
Contributor

lynnfel commented Aug 5, 2021

Section Number 2:104.4.1.3 https://profiles.ihe.net/ITI/PIXm/ITI-104.html#23104413-expected-actions

Issue conditional update, but not really. see below

Proposed Change
Preface: Someone can tell me I'm wrong about this...

In ITI-104, we say the following (italics are my comments):

2:3.104.4.1.3 Expected Actions
The Patient Identifier Cross-reference Manger SHALL provide a CapabilityStatement with the capabilities interaction and indicate that conditionalUpdate is available on the Patient. (OK... then, if I'm a a client reading/processing the capability statement, I can reasonably assume that this server provides conditional update, as defined in FHIR, on Patient Resources, ...but wait...)

A Patient Identifier Cross-reference Manager SHALL support the Conditional Update based on a patient identifier (I don't know what Conditional Update ** based on patient identifier** means) as outlined in http://hl7.org/fhir/http.html#cond-update. The Patient Identifier Cross-reference Manager MAY create a Patient resource on a Conditional update/create but is not required to do so This specifically (and intentionally) contradict the behavior specified in http://hl7.org/fhir/http.html#cond-update; there is no requirement on PIX Manager to manage Patient resources, only to cross-correlate provided identifiers.

I'm not sure what the value is of saying we are doing a conditional update, when we're not (it seems). In that case, we should just specify the expected behavior directly in ITI-104 since it seems to be so different than what a server does for a "real" conditional update as defined here http://hl7.org/fhir/http.html#cond-update

Also,
Should we specify that the [search parameters] in the PUT shall contain at least patient ID and assigning authority?

2:3.104.4.2.4 Response message
See http://hl7.org/fhir/http.html#cond-update for response. Similarly, the response semantics defers completely to FHIR; is that adequate for how we're using conditional update?

Priority:

  • Medium: Significant issue or clarification. Requires discussion, but should not lead to long debate.
@lynnfel lynnfel added the invalid This doesn't seem right label Aug 5, 2021
@oliveregger oliveregger self-assigned this Sep 11, 2021
@oliveregger
Copy link
Contributor

oliveregger commented Sep 11, 2021

I'm not sure what the value is of saying we are doing a conditional update, when we're not (it seems).

We are doing a Conditional Update, this is also mentioned in the FHIR spec: This variant can be used to allow a stateless client (such as an interface engine) to submit updated results to a server,

. The Patient Identifier Cross-reference Manager MAY create a Patient resource on a Conditional update/create but is not
required to do so This specifically (and intentionally) contradict the behavior specified in http://hl7.org/fhir/http.html#cond
-update; there is no requirement on PIX Manager to manage Patient resources, only to cross-correlate provided identifiers.

This is correct, thats why we added the MAY (or may). I don't see the contradiction, I think we need further discussion on this.

Should we specify that the [search parameters] in the PUT shall contain at least patient ID and assigning authority?
yes, this is also related to #71

@oliveregger
Copy link
Contributor

discussion about:

This update interaction creates a new current

this issue is the may create in the conditional update description. need further discussion.

@oliveregger
Copy link
Contributor

for further discussion: can we add a text that we are using the API in circumstances where there is no real create?

@oliveregger
Copy link
Contributor

Instead of:

The Patient Identifier Cross-reference Manager may create a Patient resource on a Conditional update/create but is not required to do so, there is no requirement on PIX Manager to manage Patient resources, only to cross-correlate provided identifiers.

I suggest to word it the following way:

The Patient Identifier Cross-reference Manager is not required to return a Patient resource, only to cross-correlate provided identifiers.

See also somehow related Zulip discussion on Response to Create Interaction:

None of that requires that the resource exist or be available, but it does imply that some record of the transaction needs to be retained (unless the location is a random UUID and you regard references to resources by UUID as likely a reference to a past resource and you don't care about integrity)

@oliveregger
Copy link
Contributor

change cross-correlate to cross-reference

@oliveregger
Copy link
Contributor

The Patient Identifier Cross-reference Manager is not required to return a Patient resource, only to cross-correlate provided identifiers.

change to:

The Patient Identifier Cross-reference Manager is not required to maintain a Patient resource, only to cross-reference provided identifiers.

oliveregger added a commit that referenced this issue Oct 21, 2021
oliveregger added a commit that referenced this issue Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants