You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Actually, there is no restart route for a service. But it could be useful in different cases. For instance, now, it is easy to add and the other admin routes are not available. But in the future, if you have a problem with a specific route, a restart could be useful.
Tasks
Update API doc to be sure of the IO (ex. GET or POST, responses if ok or not).
Code it (see next paragrah)
Update doc (ex. functionalities, changelog)
Update tests (new classes if there are; rtest for this route)
Test memory leaks? Tested manually, but an issue where created to investigate it in a more detailed way. See [fix] Analyse memory issues #57
Run tests inside docker (rtest, ctest, utest, itest)
Code
Add the route inside the router of the admin API
Create a function inside the administrator to handle this restart
Create a function inside the serviceManager to stop and load the service (this is the restart)
Create the same function inside administeredService and its child classes (serviceProcess and serviceInsider) to stop the service. The function to load the service has already been written.
serviceInsider : call to this._serviceInstance.stopAllServers() and this._serviceInstance = null to let the garbage collector take it
serviceProcess : send a kill via this._serviceInstance.kill(), and this._serviceInstance = null to let the garbage collector take it
Modify service.initIPC() to add a process.on('SIGKILL') which call this.stopAllServers()
The text was updated successfully, but these errors were encountered:
Need
Actually, there is no restart route for a service. But it could be useful in different cases. For instance, now, it is easy to add and the other admin routes are not available. But in the future, if you have a problem with a specific route, a restart could be useful.
Tasks
Code
The text was updated successfully, but these errors were encountered: