-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New maidroid version #3
Comments
Very nice, if you are interested, you can try submitting it here: https://github.com/minetest-mods/minetest-mods.github.io/issues/new?title=New%20mod%20request My technical level is limited, I can only fix bugs a little and add other people's improvements. If you are willing to submit to the official platform, it will be beneficial to the improvement and maintenance of mods. In addition, since the mod has been merged into a single mod from the mod package, the difference is relatively large, So I'm not going to merge everything from your version. Thank you so much for your contribution to this project! |
https://content.minetest.net/packages/mazes/maidroid_ng/ Also I found that you have two versions of maidroid, [maidroid] is updated later than [maidroid_ng], why not put the former in content.minetest.net? |
At least don't revert to buggy behavior after merging fix. It was the point were I preferred to fork.
It is already in content.minetest.net, but technical names collides. I quite don't understand as you got the link |
Le Fri, 19 Aug 2022 07:31:53 -0700,
zichen ***@***.***> a écrit :
https://content.minetest.net/packages/mazes/maidroid_ng/
Also I found that you have two versions of maidroid, [maidroid] is
updated later than [maidroid_ng], why not put the former in
content.minetest.net?
maidroid_ng is already in CDB. It is backward compatible with your
version and share the same technical name, very annoying for cdb.
"ng" can migrate "old" entities to "ng", but then they are not more
usable with "old" maidroid.
Latest patch I sent to you was supposed to avoid getting 2
seeds each time planting something, however you immediately patched
back to use 2 seeds or 1 if place_seed fails
e635bad:
stack = farming.place_seed(stack, minetest.get_player_by_name(self.owner_name), pointed_thing, plantname)
+ stack:take_item(1)
it is not needed as the call to stack = farming.place_seed already
updates the stack accordingly to what was used.
This did really not look promising to me, so I decided to fork.
There's a lot of updates and new features in my version, feel free to
merge them in a "ng" branch.
However if you are not technical enough it may be hard for you to
understand those changes despite I'm noob to minetest lua interface.
You may also give access to "ng" branch to me, so I can get user
feedback if any.
Wow it took real long time to reply :)
|
Hi, I am working on a new maidroid version
https://gitlab.com/mazes_80
There's a lot of new features and I see your version does not receive much work now
Tell me what you think about integrating those new changes
The text was updated successfully, but these errors were encountered: