Skip to content
This repository has been archived by the owner on Sep 4, 2024. It is now read-only.

[Staging] Browser Back button behaviour on Search page #2702

Open
batpad opened this issue Mar 29, 2023 · 1 comment
Open

[Staging] Browser Back button behaviour on Search page #2702

batpad opened this issue Mar 29, 2023 · 1 comment

Comments

@batpad
Copy link
Contributor

batpad commented Mar 29, 2023

Issue

This is pretty minor, but just to have it filed. The browser back button does not work as expected after clicking on for eg. "View all Emergencies" on the search page.

URL

https://go-stage.ifrc.org/search?keyword=switzerland

Steps to reproduce

Click on View All Emergencies. Then click the browser back button.

Expected: To be taken back to search results page for Switzerland

Actual: For me, this takes me back to my browser default start page, which is really strange. At the very least, it should keep me on the GO site.

Expected behaviour

The browser back button should work exactly like the "Go Back" button on the page after clicking "View all Emergencies". The "Go Back" button takes me back to the search results page, and I'd expect my browser back button to do the same.

Criticality/Urgency

Low. The browser back button not working as expected is a pet peeve of mine, but I wouldn't prioritize over other urgent things.

This does seem like it might be a bit complex to fix since we don't actually change the URL between the search results page and clicking a "View all Emergencies" or so. I think an ideal solution might involve having an explicit URL state change when navigating to "View all Emergencies" though I can see how that might involve a larger refactor.

Any-how, just filing this to note.

cc @frozenhelium @tovari

@nanometrenat
Copy link
Contributor

@batpad is work still required here, post-rewrite? Cheers

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants