Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Non Partitioned Containers #475

Open
janrhijn opened this issue Sep 24, 2024 · 2 comments
Open

Add Support for Non Partitioned Containers #475

janrhijn opened this issue Sep 24, 2024 · 2 comments

Comments

@janrhijn
Copy link

janrhijn commented Sep 24, 2024

Is your feature request related to a problem? Please describe.
We have some (older) containers which aren't partitioned. We are unable to use this (super handy) package because this is not supported in IEvangelist. In the Microsoft.Azure.Cosmos package itself we can us PartitionKey.None when the container isn't partitioned.

Describe the solution you'd like
Implement PartitionKey.None so it can be used with a container which partitioned, similar as it is used with Microsoft.Azure.Cosmos

Describe alternatives you've considered
Overriding GetPartitionKeyValue() with PartitionKey.None.ToString();. This doesn't work, because this will create a new Item with a partitionkey with value null (which is not the same as no partitionkey at all).

@janrhijn janrhijn changed the title Add Support for PartionKey.None Add Support for Non Partitioned Containers Sep 24, 2024
@marcselman
Copy link

I would love to see this implemented. This should have been supported from the start in my opinion.

@IEvangelist
Copy link
Owner

What would be involved in implementing this? I've been really buried lately, and admittedly have had zero time for side projects, namely this project, but I know lots of folks rely on it. I could make time to review a PR if either of you @janrhijn and/or @marcselman are interested in giving that a try?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants