Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for read/write client separation #324

Open
dnitsch opened this issue Mar 20, 2023 · 6 comments
Open

Allow for read/write client separation #324

dnitsch opened this issue Mar 20, 2023 · 6 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed up-for-grabs 🙏🏽 Happy to consider a pull review to address this issue

Comments

@dnitsch
Copy link

dnitsch commented Mar 20, 2023

Is your feature request related to a problem? Please describe.

Related to this discussion

Describe the solution you'd like

The caller should be allowed to pass in a read and/or write endpoints. If omitted the default account endpoint to be used for operations of both types.

If writeEndpoint is supplied the underlying write operations i.e. all methods in the IWriteRepository and IBatchRepository should use it, similarly for the reads.

This might require storing 2 versions of the client on the struct as a private properties... 🤷‍♂️

Describe alternatives you've considered
Implementation still needs ironing out

Additional context

Currently scenarios requiring multi region setup with strong consistency cannot be properly satisfied, where writes should only occur into a single region.

@IEvangelist IEvangelist added the enhancement New feature or request label Mar 22, 2023
@IEvangelist IEvangelist added help wanted Extra attention is needed up-for-grabs 🙏🏽 Happy to consider a pull review to address this issue labels Apr 6, 2023
@IEvangelist
Copy link
Owner

@all-contributors please add @dnitsch for idea

@allcontributors
Copy link
Contributor

@IEvangelist

I've put up a pull request to add @dnitsch! 🎉

@mumby0168
Copy link
Collaborator

@dnitsch I know we had a chat about this and you had found that this wasn't required due to the SDK knowing which endpoints to hit in which scenarios under the hood. Are you able to provide the detail you gave to me on this issue?

@dnitsch
Copy link
Author

dnitsch commented Apr 28, 2023

Hey @mumby0168 - sorry about the delay. I'll update the discussion issue today.

@mumby0168
Copy link
Collaborator

Hi @dnitsch were you okay to update this issue with your findings?

Thanks.

@dnitsch
Copy link
Author

dnitsch commented Sep 20, 2023

@mumby0168 - ended up updating the discussion issue instead.

Now, need to find the time to submit the idea/suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed up-for-grabs 🙏🏽 Happy to consider a pull review to address this issue
Projects
None yet
Development

No branches or pull requests

3 participants