Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Continuation Token Paging Support to the InMemoryRepository<T> #161

Open
mumby0168 opened this issue Jan 6, 2022 · 2 comments
Open
Labels
help wanted Extra attention is needed up-for-grabs 🙏🏽 Happy to consider a pull review to address this issue

Comments

@mumby0168
Copy link
Collaborator

We have recently introduced paging into the DefaultRepository<T> but there is not yet support for the continuation token version in the InMemoryRepository<T>. This could return a Guid as the token and just use Skip().Take() under the hood.

@mumby0168 mumby0168 added the up-for-grabs 🙏🏽 Happy to consider a pull review to address this issue label Jan 6, 2022
@mumby0168
Copy link
Collaborator Author

Hey @robertbennett1998 @IEvangelist

I know Rob you've raised this issue Azure/azure-cosmos-dotnet-v3#2987 around the complications with replicating continuation tokens.

I was wondering what both your thoughts were on doing an implementation of this maybe ignoring some of the complications, as long as we document it?

I came to this thought as if you were using the in-memory repository to test some of these niche cases where a document is inserted mid-page for example, I would say you are doing something wrong, I'd say you should be testing against the real service.

Let me know what you both think.

@robennett2
Copy link
Collaborator

I was thinking about this, I think we could do something with hashing the object and saving the index that object was in. This would allow us to replicate that behivour in that thread. I will try to have a look at it it tomorrow night / early next week.

We could do a basic implementation now and document it but it would be frustrating especially if it was implemented at a later date and broke unit tests etc.

@IEvangelist IEvangelist added the help wanted Extra attention is needed label Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed up-for-grabs 🙏🏽 Happy to consider a pull review to address this issue
Projects
None yet
Development

No branches or pull requests

3 participants