spotbugs

pom.xml

@@ -44,6 +44,12 @@
             <artifactId>spring-boot-configuration-processor</artifactId>
             <optional>true</optional>
         </dependency>
+        <dependency>
+            <groupId>com.github.spotbugs</groupId>
+            <artifactId>spotbugs-annotations</artifactId>
+            <version>4.8.6</version>
+            <scope>compile</scope>
+        </dependency>
     </dependencies>
     <build>
         <plugins>
@@ -109,7 +115,7 @@
                 <executions>
                     <execution>
                         <id>check</id>
-                        <phase>validate</phase>
+                        <phase>test</phase>
                         <goals>
                             <goal>check</goal>
                         </goals>

src/main/java/nl/ictu/Token.java

@@ -18,7 +18,9 @@ public final class Identifier {
         private String value;
     }
 
-    private final String version = "v1";
+    @edu.umd.cs.findbugs.annotations.SuppressFBWarnings("SS_SHOULD_BE_STATIC")
+    private String version = "v1";
+
     private String recipientOIN;
     private Identifier identifier = new Identifier();
 

src/main/java/nl/ictu/service/CryptographerImpl.java

@@ -69,7 +69,7 @@ public String decrypt(final String ciphertextWithIv) throws NoSuchPaddingExcepti
 
         byte[] decryptedText = cipher.doFinal(ciphertext);
 
-        return new String(decryptedText);
+        return new String(decryptedText, StandardCharsets.UTF_8);
 
     }