Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase test coverage of BaseMonitor and monitor implementations #25

Open
csmuller opened this issue Oct 10, 2018 · 0 comments
Open

Increase test coverage of BaseMonitor and monitor implementations #25

csmuller opened this issue Oct 10, 2018 · 0 comments

Comments

@csmuller
Copy link
Member

The BaseMonitor and its subclasses have successfully been tested manually but should also get better unit test coverage.
Things to write unit tests for are:

  • processing of pending transactions (BaseMonitor)
  • processing of building transactions (BaseMonitor)
    • Minimum payment amount
    • creation of refund entries on specific failures
  • Monitor specific implemenations in BitcoinMonitor and EthereumMonitor, although it might not be possible to set up the environment to perform all desired tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@csmuller