Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new Carbon Combobutton for scan button in Checker #1842

Closed
drjoho opened this issue Feb 15, 2024 · 4 comments · Fixed by #2137
Closed

Use new Carbon Combobutton for scan button in Checker #1842

drjoho opened this issue Feb 15, 2024 · 4 comments · Fixed by #2137
Assignees
@nam-singh
Labels
extension-checker Issues related to the browser extensions priority-2 (med) T61

Comments

@drjoho
Copy link
Contributor

drjoho commented Feb 15, 2024 •
edited
Loading

Mike Abbink
FYI
@jess

@alexandra
The checker can update with the new combo button. If I remember correctly this behaves that way. If not, then disregard.
https://react.carbondesignsystem.com/?path=/story/components-combobutton--default&globals=theme:white (edited)

Need to update carbon to get the new Combobutton and do significant testing due to the update.
@shunguoy shunguoy added the T61 label Feb 19, 2024
@shunguoy
Copy link
Contributor

triage: discuss w/ @drjoho on the priority of the issue and if it can be put in the current release.

@drjoho drjoho self-assigned this Feb 23, 2024
@marcjohlic marcjohlic added the extension-checker Issues related to the browser extensions label Feb 23, 2024
@tombrunet
Copy link
Member

Image

@MHoov MHoov assigned nam-singh and unassigned drjoho Dec 17, 2024
@tombrunet
Copy link
Member

The Scan and dropdown were initially implemented as two separate widgets. Carbon now has a Combobutton that may be able to use a more Carbon supported means of doing this.

@nam-singh nam-singh mentioned this issue Dec 28, 2024
Merged
11 tasks
@nam-singh
Copy link
Contributor

Fixes in PR:#2137
Video WalkThrough:https://ibm-my.sharepoint.com/:v:/p/nam_singh/EYQoSBbppjpLoCrfMhgka_kBCBbDuW5R8mNMLC88LoSSgQ?nav=eyJyZWZlcnJhbEluZm8iOnsicmVmZXJyYWxBcHAiOiJPbmVEcml2ZUZvckJ1c2luZXNzIiwicmVmZXJyYWxBcHBQbGF0Zm9ybSI6IldlYiIsInJlZmVycmFsTW9kZSI6InZpZXciLCJyZWZlcnJhbFZpZXciOiJNeUZpbGVzTGlua0NvcHkifX0&e=YW29j4

tombrunet added a commit that referenced this issue Jan 2, 2025
@nam-singh @tombrunet
chore(extension): carbon package update and use new carbon combobutton
83eaa93 
#1842 (#2137)

* carbon package update and use new carbon combobutton

* alignment fix

---------

Co-authored-by: Tom Brunet <[email protected]>
tombrunet added a commit that referenced this issue Jan 14, 2025
@tombrunet @dependabot @nam-singh
chore(repo): Update main-4.x for Jan release (#2148)
981a467 
* Bump path-to-regexp and express in /rule-server (#2128)

Bumps [path-to-regexp](https://github.com/pillarjs/path-to-regexp) to 0.1.12 and updates ancestor dependency [express](https://github.com/expressjs/express). These dependencies need to be updated together.


Updates `path-to-regexp` from 0.1.10 to 0.1.12
- [Release notes](https://github.com/pillarjs/path-to-regexp/releases)
- [Changelog](https://github.com/pillarjs/path-to-regexp/blob/master/History.md)
- [Commits](pillarjs/path-to-regexp@v0.1.10...v0.1.12)

Updates `express` from 4.21.0 to 4.21.2
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/4.21.2/History.md)
- [Commits](expressjs/express@4.21.0...4.21.2)

---
updated-dependencies:
- dependency-name: path-to-regexp
  dependency-type: indirect
- dependency-name: express
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tom Brunet <[email protected]>

* fix dark mode react portal pop-up (#2138)

* fix(extension):Fix reset filter link #1877 (#2136)

* reset filter fix

* css fix

---------

Co-authored-by: Tom Brunet <[email protected]>

* fix(extension): Don't show full data:text/html content on generated HTML report page  (#2140)

* truncating url

* remove unused import

* Adjust tooltip location

---------

Co-authored-by: Tom Brunet <[email protected]>

* chore(extension): carbon package update and use new carbon combobutton #1842 (#2137)

* carbon package update and use new carbon combobutton

* alignment fix

---------

Co-authored-by: Tom Brunet <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Namrata Singh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nam-singh nam-singh

Labels
extension-checker Issues related to the browser extensions priority-2 (med) T61
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(extension): carbon package update and use new carbon combobutton #1842 IBMa/equal-access
5 participants
@marcjohlic @shunguoy @tombrunet @drjoho @nam-singh