Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit and Restart and Wait... forever #289

Open
Warkdev opened this issue Nov 6, 2020 · 0 comments
Open

Commit and Restart and Wait... forever #289

Warkdev opened this issue Nov 6, 2020 · 0 comments

Comments

@Warkdev
Copy link

Warkdev commented Nov 6, 2020

Hello,

This function does work as expected if something has changed. However, if there was no change, this function will loop until timeout and send back a warning: https://github.com/IBM-Security/ibmsecurity/blob/master/ibmsecurity/isam/appliance.py#L140

To avoid this, you should first check if there are changes (_changes_available()) function and, if yes, proceed with restart (ideally adding the flag Force to True to avoid checking again for changes).

Would speed up some deployments :)

Cédric Servais

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant