diff --git a/frontend/cypress/pages/HomePage.js b/frontend/cypress/pages/HomePage.js index 4175ff4691..c22181af3f 100755 --- a/frontend/cypress/pages/HomePage.js +++ b/frontend/cypress/pages/HomePage.js @@ -19,8 +19,8 @@ class HomePage { goToOrderPage() { this.openNavigationMenu(); - cy.get("#menu_sample").click(); - cy.get("#menu_sample_add").click(); + cy.get("#menu_sample_dropdown").click(); + cy.get("#menu_sample_add_nav").click(); return new OrderEntityPage(); } @@ -32,69 +32,69 @@ class HomePage { goToBatchOrderEntry() { this.openNavigationMenu(); - cy.get("#menu_sample").click(); - cy.get("#menu_sample_batch_entry").click(); + cy.get("#menu_sample_dropdown").click(); + cy.get("#menu_sample_batch_entry_nav").click(); return new BatchOrderEntry(); } goToPatientEntry() { this.openNavigationMenu(); - cy.get("#menu_patient").click(); - cy.get("#menu_patient_add_or_edit").click(); + cy.get("#menu_patient_dropdown").click(); + cy.get("#menu_patient_add_or_edit_nav").click(); return new PatientEntryPage(); } goToModifyOrderPage() { this.openNavigationMenu(); - cy.get("#menu_sample").click(); - cy.get("#menu_sample_edit").click(); + cy.get("#menu_sample_dropdown").click(); + cy.get("#menu_sample_edit_nav").click(); return new ModifyOrderPage(); } goToWorkPlanPlanByTest() { this.openNavigationMenu(); - cy.get("#menu_workplan").click(); - cy.get("#menu_workplan_test").click(); + cy.get("#menu_workplan_dropdown").click(); + cy.get("#menu_workplan_test_nav").click(); return new WorkPlan(); } goToWorkPlanPlanByPanel() { this.openNavigationMenu(); - cy.get("#menu_workplan").click(); - cy.get("#menu_workplan_panel").click(); + cy.get("#menu_workplan_dropdown").click(); + cy.get("#menu_workplan_panel_nav").click(); return new WorkPlan(); } goToWorkPlanPlanByUnit() { this.openNavigationMenu(); - cy.get("#menu_workplan").click(); - cy.get("#menu_workplan_bench").click(); + cy.get("#menu_workplan_dropdown").click(); + cy.get("#menu_workplan_bench_nav").click(); return new WorkPlan(); } goToWorkPlanPlanByPriority() { this.openNavigationMenu(); - cy.get("#menu_workplan").click(); - cy.get("#menu_workplan_priority").click(); + cy.get("#menu_workplan_dropdown").click(); + cy.get("#menu_workplan_priority_nav").click(); return new WorkPlan(); } goToReportNCE() { this.openNavigationMenu(); - cy.get("#menu_nonconformity").click(); - cy.get("#menu_non_conforming_report").click(); + cy.get("#menu_nonconformity_dropdown").click(); + cy.get("#menu_non_conforming_report_nav").click(); return new NonConform(); } goToViewNCE() { this.openNavigationMenu(); - cy.get("#menu_nonconformity").click(); - cy.get("#menu_non_conforming_view").click(); + cy.get("#menu_nonconformity_dropdown").click(); + cy.get("#menu_non_conforming_view_nav").click(); return new NonConform(); } goToCorrectiveActions() { this.openNavigationMenu(); - cy.get("#menu_nonconformity").click(); - cy.get("#menu_non_conforming_corrective_actions").click(); + cy.get("#menu_nonconformity_dropdown").click(); + cy.get("#menu_non_conforming_corrective_actions_nav").click(); return new NonConform(); } } diff --git a/frontend/src/components/Style.css b/frontend/src/components/Style.css index 21b2711611..d1f629f5b6 100644 --- a/frontend/src/components/Style.css +++ b/frontend/src/components/Style.css @@ -498,13 +498,18 @@ button { padding-left: 1rem !important; } -.cds--side-nav__link:hover { +.top-level-menu-item > a { + pointer-events: auto !important; + text-decoration: none !important; +} + +.top-level-menu-item > a:hover { background-color: var(--cds-background-hover, #072655); } -/* .cds--side-nav__link { +#mainHeader .cds--side-nav__link { pointer-events: none -} */ +} @media screen and (max-width: 792px) { .banner h5 { diff --git a/frontend/src/components/layout/Header.js b/frontend/src/components/layout/Header.js index aa41f26d55..f4e080bb11 100644 --- a/frontend/src/components/layout/Header.js +++ b/frontend/src/components/layout/Header.js @@ -184,14 +184,15 @@ function OEHeader(props) { if (menuItem.menu.isActive) { if (level === 0 && menuItem.childMenus.length > 0) { return ( - + { setMenuItemExpanded(e, menuItem, path); }} > { - setMenuItemExpanded(e, menuItem, path); - }} + // onClick={(e) => { // not supported yet, but if it becomes so we can simplify the functionality here by having this here and not have a span around it + // setMenuItemExpanded(e, menuItem, path); + // }} > - {menuItem.childMenus.map((childMenuItem, index) => { - return generateMenuItems( - childMenuItem, - index, - level + 1, - path + ".childMenus[" + index + "]", - ); - })} + { + e.preventDefault(); + e.stopPropagation(); + }} + > + {menuItem.childMenus.map((childMenuItem, index) => { + return generateMenuItems( + childMenuItem, + index, + level + 1, + path + ".childMenus[" + index + "]", + ); + })} + - + ); } else if (level === 0) { return ( - + {renderSideNavMenuItemLabel(menuItem, level)} - + ); } else { return ( - - + + {!menuItem.menu.actionURL && !hasActiveChildMenu(menuItem) && @@ -261,7 +276,7 @@ function OEHeader(props) { ); })} - + ); } } else { @@ -284,27 +299,20 @@ function OEHeader(props) { const renderSingleNavButton = (menuItem, index, level, path) => { const marginValue = (level - 1) * 0.5 + "rem"; return ( - { + if (menuItem.menu.openInNewWindow) { + window.open(menuItem.menu.actionURL); + } else { + window.location.href = menuItem.menu.actionURL; + } + }} > - - + {renderSideNavMenuItemLabel(menuItem, level)} + ); }; @@ -329,31 +337,24 @@ function OEHeader(props) { const marginValue = (level - 1) * 0.5 + "rem"; return ( <> - - - + }} + > + {renderSideNavMenuItemLabel(menuItem, level)} + {menuItem.childMenus.length > 0 && (