Skip to content
This repository has been archived by the owner on Jun 18, 2024. It is now read-only.

SSO integration is missing #1

Open
siaen opened this issue Apr 29, 2020 · 0 comments
Open

SSO integration is missing #1

siaen opened this issue Apr 29, 2020 · 0 comments

Comments

@siaen
Copy link

siaen commented Apr 29, 2020

Hi,

I have started to use Hyvor Talk and so far it is very positive.

One caveat of this small react injector component is that it is forcing you to use a recreated HYVOR_TALK_CONFIG configuration in:
createClass(Embed, [{ key: 'setVariables', value: function setVariables() { window.HYVOR_TALK_WEBSITE = this.props.websiteId; window.HYVOR_TALK_CONFIG = { url: this.props.url || false, id: this.props.id || false, loadMode: this.props.loadMode || 'default' }; }

Either injecting a config to Embed or having the option that you have that variable already setup (my case) would be good.

I had to carve out this code and manually edit the piece to make it work.

Regards,

Marton

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant