Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Kia EU) Push notification integration #144

Open
zulufoxtrot opened this issue Nov 23, 2022 · 3 comments
Open

(Kia EU) Push notification integration #144

zulufoxtrot opened this issue Nov 23, 2022 · 3 comments
Assignees

Comments

@zulufoxtrot
Copy link
Collaborator

It looks like an integration of Google Cloud Messaging was attempted at some point by @fuatakgun :

        try:
            credentials = push_receiver.register(sender_id=self.GCM_SENDER_ID)
            registration_id = credentials["gcm"]["token"]
        except:
            pass

push_register is a Google Cloud Messaging (GCM) / FIrebase Cloud Messaging (FCM) client library.
I assume the intended application was to retrieve push notifications the way the native app does it.

This was removed in new releases. Why?

@cdnninja
Copy link
Collaborator

Orignally this code came from here https://github.com/fuatakgun/kia_uvo/blob/master/custom_components/kia_uvo/KiaUvoApiEU.py

I believe it was removed because push_receiver as a library is no longer supported and has deprecated libraries so was a ticking time bomb on some of our users systems.

Hyundai-Kia-Connect/kia_uvo#345

@cdnninja
Copy link
Collaborator

In theory a new fork of push_receiver could be created with updated dependencies to continue that approach.

@zulufoxtrot
Copy link
Collaborator Author

OK. I looked around and found other similar libraries.
In theory there could be useful use cases for a notification client.
We'd need to check how it works in practice. I believe each client (mobile app) or user has a unique ID/token, and it may not be easy to obtain.

@fuatakgun fuatakgun self-assigned this Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants