Skip to content
This repository has been archived by the owner on Sep 9, 2024. It is now read-only.

New welcome screen #8

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

engalali9
Copy link
Contributor

Screenshot from 2022-04-13 23-35-06

@nathandyer
Copy link
Collaborator

@ali-sameh-galal Good day! Thanks for this PR!

I tried this out on my system to see how I felt about it in practice, but so far I don't think I'm a fan of this change. This is what I see when I launch it on my system:

Screenshot from 2022-04-15 08-16-32

The main issues I have with it are:

  • The welcome screen appears in the center, while the main window is in another spot
  • I can't move either the welcome screen or the main window until I acknowledge the welcome screen and click Get Started
  • Overall, I feel like it's less cohesive

Is there a benefit to having the welcome screen broken out into a separate window like this? If so, I'm certainly open to being persuaded, but right now I'm not convinced this would be a beneficial change.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants