Skip to content
This repository has been archived by the owner on Sep 9, 2024. It is now read-only.

Make Hypatia adaptive in small screens (phones) #7

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

engalali9
Copy link
Contributor

@engalali9 engalali9 commented Apr 10, 2022

Hypatia is now adaptive but it will need a

  1. New Welcome Window instead of the old Welcome Box.
  2. Way to open the image in a new window and ability to Download it.
  3. New searchbar (phone) i think the existed one is good but it will need a new one for better UX.

Before :

222

After :

111
333

@nathandyer
Copy link
Collaborator

@ali-sameh-galal Thank you for this PR! Great work as always!

I do want to hold off on merging until it's a bit more complete, because it's missing several critical things:

  • As you mention, there's no welcome screen, and no way to get back to that information. Many users will be finding Hypatia directly within GNOME Software / Pop!_Shop / AppCenter, etc., and may not read the description, so it's important that they understand how it works.
  • It's important to me that a user can use trackpad gestures, or click-and-drag with the mouse, on one view to get to another. That's working in the current version, but I couldn't reproduce in this one. The great thing is this benefit for trackpad users will apply for mobile users too (they can swipe between views, rather than having to click the button on the switcher).
  • As you note, the search bar is a little funky. Something broke a bit in this iteration, it looks like the revealer is spaced a bit away from the original, so instead of just "turning into" the search bar, it's like it reveals its position farther down the line.
  • When in a wider mode, I think it's important that the image be to the right of the text, not above it. The information in the instant answer is almost always going to be more important than the accompanying image, and by putting it above the information, it's possible for folks on certain devices to only see the photo without even knowing the result is below it.
  • Can you elaborate more about why it would be necessary to load the image in a new window? I can understand in some cases why someone might want to save it, but I don't understand the benefit of another window.

All that being said, this is a great start for making it more adaptive! Thanks for the effort so far!

@nathandyer nathandyer added enhancement New feature or request changes requested labels Apr 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
changes requested enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants