Dark Mode for Spot #135
Dark Mode for Spot #135
Conversation
ACoderGuy1002
requested review from
jinanparves
and removed request for
nithilan4
Also, added go-to analysis button! Yay. |
- Made the menu icon smaller - Made the reload button turn white - "changecolor.js" changed to "settingsmenu.js"
|
I found one bug and have two suggestions. Bug The hit target for the hamburger settings icon is discontiguous. At times whenI tried to click the settings icon, the click/tap wasn't registered. This can be seen in the highlights in this gif:
Suggestion I would expect that when I select "Dark Mode" on the setting popup, that the popup is dismissed. Instead, after I click "Dark Mode", I have to click off the popup to dismiss it. When I'm in dark mode, the settings popup still says "Dark Mode". Since this is a button and not a checkbox, the label should start with a verb. For example "Enable Dark Mode" and "Disable Dark Mode" would be labels that clearly indicate the action that is taken when the user clicks on it. |
I have finished the dark mode for spot. It is using a slightly older version of the code (not the new beta 2024 version) so you might have to check over that to make sure its good, but other than that, I have tested all of the code, and it works great! Also, I know its a slightly big button for just dark mode, but I like big buttons.
