Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy paste error? #2

Open
galou opened this issue Jul 30, 2015 · 1 comment
Open

Copy paste error? #2

galou opened this issue Jul 30, 2015 · 1 comment

Comments

@galou
Copy link

galou commented Jul 30, 2015

First of all, thanks for contributing this code to the community! I'm planing to drive a PhantomX with ROS and will probably make use of you simulation for the development.

I just noticed something that looks like a copy-and-paste error:
walker.py: l. 88, f3.scale *= -1 should probably read f4.scale *= -1.

@Philippe-Capdepuy
Copy link
Member

Hi,
You're welcome, and your contributions appreciated.
The walk algorithm has been ported from that of our darwin_gazebo package with minor adaptations so a copy-paste error is likely, however the correct version is to remove both f3.scale and f4.scale changes. Actually the straight walk is not that straight, so if you get a better one that'd be great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants