Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For local development, we have been mapping
hubs.local
tolocalhost
via entries in the hostfile (/etc/hosts
). With this docker setup, the services are running in separate containers and thus should not map tolocalhost
for cross-service traffic.Add
extra_hosts
so thathubs.local
andhubs-proxy.local
resolve to thehost-gateway
and containers can reach one another. It seems thathost.docker.internal
also only works for me (on linux) if it is included as anextra_host
.I don't know if this is the correct solution. I was inspired by this stackoverflow answer https://stackoverflow.com/a/70725882 , which comes with a warning and recommendation to define a custom
network
definition that will guarantee a specific gateway address.Incidentally, @keianhzo 's open PR defines a
subnet
for thehubs_network
: https://github.com/mozilla/hubs-compose/pull/16/files#diff-e45e45baeda1c1e73482975a664062aa56f20c03dd9d64a827aba57775bed0d3R166-R170Following the advice linked above, we would add a
gateway:
to the config (and perhaps anip_range
, if necessary).