Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs with Brazilian/Portuguese internationalization #274

Open
nickserv opened this issue Aug 31, 2022 · 1 comment
Open

Bugs with Brazilian/Portuguese internationalization #274

nickserv opened this issue Aug 31, 2022 · 1 comment
Labels

Comments

@nickserv
Copy link
Contributor

nickserv commented Aug 31, 2022

Root

GET / HTTP/1.1
Accept-Language: pt
Host: youmightnotneedjquery.com
  1. HTML/HTTP language is not set
  2. Language is English, should be Portuguese

Brazilian/Portuguese

GET /br HTTP/1.1
Accept-Language: en
Host: youmightnotneedjquery.com
  1. HTML/HTTP language is not set
  2. Language is Portuguese, should be English
  3. JS error in console:
Uncaught ReferenceError: getInitialSliderState is not defined
    at HTMLDocument.<anonymous>
  1. No interactivity due to JS error
@nickserv nickserv changed the title Issues with Brazilian/Portuguese internationalization BUgs with Brazilian/Portuguese internationalization Aug 31, 2022
@nickserv nickserv changed the title BUgs with Brazilian/Portuguese internationalization Bugs with Brazilian/Portuguese internationalization Aug 31, 2022
@Abbondanzo Abbondanzo added the bug label Sep 1, 2022
@nickserv
Copy link
Contributor Author

nickserv commented Sep 2, 2022

Once we finish #266 it should be easier to extract internationalization data into separate files with shared logic.

@Abbondanzo Abbondanzo mentioned this issue Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants