New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redundant if conditions in the code #431

Open

29avet1 opened this issue Dec 13, 2024 · 0 comments

29avet1 commented Dec 13, 2024

it looks like you have lots of redundant if conditions. basically, it's the same check copied in different files.
here are example files

https://github.com/HubSpot/hubspot-api-php/blob/master/codegen/Crm/Associations/V4/Api/BasicApi.php#L1372
https://github.com/HubSpot/hubspot-api-php/blob/master/codegen/Crm/Associations/V4/Api/BasicApi.php#L1376

https://github.com/HubSpot/hubspot-api-php/blob/master/codegen/Crm/Contacts/Api/BasicApi.php#L449
https://github.com/HubSpot/hubspot-api-php/blob/master/codegen/Crm/Contacts/Api/BasicApi.php#L449

https://github.com/HubSpot/hubspot-api-php/blob/master/codegen/Crm/Companies/Api/BasicApi.php#L449
https://github.com/HubSpot/hubspot-api-php/blob/master/codegen/Crm/Companies/Api/BasicApi.php#L449

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment