Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Annotation #250

Open
sylfabre opened this issue May 24, 2023 · 0 comments
Open

Incorrect Annotation #250

sylfabre opened this issue May 24, 2023 · 0 comments

Comments

@sylfabre
Copy link

sylfabre commented May 24, 2023

Hello

I found out that the lifecycle property can be null so HubSpot\Client\Crm\Companies\Model\SimplePublicObjectWithAssociations::getProperties() may not always return an array of strings.

=> The method's annotation is incorrect: https://github.com/HubSpot/hubspot-api-php/blob/master/codegen/Crm/Companies/Model/SimplePublicObjectWithAssociations.php#LL287C31-L287C31

It should be @return array<string,string|null>.

It's important for me as it fails my static analysis run in my CI

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant