From 5c69e936ca34b087c7c4e68b27c5caab9d9efc1b Mon Sep 17 00:00:00 2001 From: ksvirkou Date: Fri, 21 Aug 2020 15:04:05 +0300 Subject: [PATCH 1/3] fix webhooks init --- .../webhooks-contacts-app/src/actions/webhooks/init.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sample-apps/webhooks-contacts-app/src/actions/webhooks/init.php b/sample-apps/webhooks-contacts-app/src/actions/webhooks/init.php index 7cf0a830..27df05d3 100644 --- a/sample-apps/webhooks-contacts-app/src/actions/webhooks/init.php +++ b/sample-apps/webhooks-contacts-app/src/actions/webhooks/init.php @@ -16,6 +16,7 @@ ; $appId = getEnvOrException('HUBSPOT_APPLICATION_ID'); +$appUrl = UrlHelper::generateServerUri().'/webhooks/handle.php'; $subscriptions = $webhooksClient->subscriptionsApi()->getAll($appId); @@ -25,7 +26,7 @@ WebhooksHelper::updateSubscriptions($appId, $activeSubscriptions, false); $request = new SettingsChangeRequest(); -$request->setTargetUrl(UrlHelper::generateServerUri().'/webhooks/handle.php'); +$request->setTargetUrl($appUrl); $response = $webhooksClient->settingsApi() ->configure($appId, $request) From a2b81204bb1a35db4aaf50eeb3f47f800b2c4d91 Mon Sep 17 00:00:00 2001 From: ksvirkou Date: Fri, 21 Aug 2020 15:25:15 +0300 Subject: [PATCH 2/3] codereview --- sample-apps/timeline-app/src/Helpers/TimelineEventHelper.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sample-apps/timeline-app/src/Helpers/TimelineEventHelper.php b/sample-apps/timeline-app/src/Helpers/TimelineEventHelper.php index 1f0dfab9..c7943884 100644 --- a/sample-apps/timeline-app/src/Helpers/TimelineEventHelper.php +++ b/sample-apps/timeline-app/src/Helpers/TimelineEventHelper.php @@ -16,7 +16,7 @@ public static function createEvent(string $telegramChatId, string $eventTypeCode $request->setId(uniqid()); $request->setEmail(UsersRepository::getEmailByTelegramChatId($telegramChatId)); $request->setEventTemplateId(EventTypesRepository::getHubspotEventIDByCode($eventTypeCode)); - + if (!empty($tokens)) { $request->setTokens($tokens); } From 6fa9c5a5576fdc6432e220d5c9113b5802ca5243 Mon Sep 17 00:00:00 2001 From: ksvirkou Date: Fri, 21 Aug 2020 15:31:04 +0300 Subject: [PATCH 3/3] fix map link --- sample-apps/trello-integration-app/src/views/readme.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sample-apps/trello-integration-app/src/views/readme.php b/sample-apps/trello-integration-app/src/views/readme.php index 0978636c..334b4487 100644 --- a/sample-apps/trello-integration-app/src/views/readme.php +++ b/sample-apps/trello-integration-app/src/views/readme.php @@ -5,7 +5,7 @@

Proceed with the following steps to see trello integration in action:

  1. Associate deal with Trello card using HubSpot interface
  2. -
  3. Map Trello board lists with HubSpot pipeline stages on mappings page
  4. +
  5. Map Trello board lists with HubSpot pipeline stages on mappings page
  6. Move associated trello card to any other mapped earlier board list and check how this affects HubSpot deal stage