Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#292 [refactor] 탈퇴/피드백 뷰 분리 #318

Merged
merged 16 commits into from
Sep 25, 2023
Merged

#292 [refactor] 탈퇴/피드백 뷰 분리 #318

merged 16 commits into from
Sep 25, 2023

Conversation

2zerozu
Copy link
Contributor

@2zerozu 2zerozu commented Sep 23, 2023 •
edited
Loading

관련 이슈

작업한 내용

  • 탈퇴/피드백 뷰 분리

PR 포인트

  • 기존 Withdraw에 Feedback, Withdraw, WithdrawDone을 피드백보내기에도 사용하고 있던 것을 Withdraw와 Feedback으로 분리하였습니다.
  • WithdrawActivity : FeedbackFragment, WithdrawFragment, WithdrawDoneFragment
  • FeedbackActivity : FeedbackFragment, FeedbackDoneFragment

@2zerozu 2zerozu self-assigned this Sep 23, 2023
@2zerozu 2zerozu added 영주🐼 영주가 작업함! ui ui 관련 작업 Pull Request🔥 풀리퀘 날림! labels Sep 23, 2023
@2zerozu 2zerozu added this to the Hous 3차 릴리즈 milestone Sep 23, 2023
murjune
murjune approved these changes Sep 23, 2023
View reviewed changes
Copy link
Member

@murjune murjune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

진짜 그래픽 추가만 이군 ㅋㅋㅋ

@2zerozu 2zerozu changed the title #292 [ui] 탈퇴완료 그래픽 추가 #292 [ui] 탈퇴완료/피드백완료 뷰 구현 Sep 23, 2023
@2zerozu 2zerozu changed the title #292 [ui] 탈퇴완료/피드백완료 뷰 구현 #292 [ui] 탈퇴완료 구현 Sep 23, 2023
@2zerozu 2zerozu changed the title #292 [ui] 탈퇴완료 구현 #292 [ui] 탈퇴완료/피드백완료 뷰 구현 Sep 23, 2023
@2zerozu 2zerozu changed the title #292 [ui] 탈퇴완료/피드백완료 뷰 구현 #292 [ui] 탈퇴완료 뷰 구현 Sep 23, 2023
@2zerozu 2zerozu changed the title #292 [ui] 탈퇴완료 뷰 구현 #292 [refactor] 탈퇴/피드백 뷰 분리 Sep 23, 2023
@2zerozu 2zerozu removed the ui ui 관련 작업 label Sep 23, 2023
@2zerozu 2zerozu added the refactor 내부 로직은 변경 하지 않고 기존의 코드를 개선하는 리팩토링 시 label Sep 23, 2023
murjune
murjune approved these changes Sep 24, 2023
View reviewed changes
Copy link
Member

@murjune murjune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다! 코멘트 확인해주세욤

app/src/main/java/hous/release/android/presentation/withdraw/WithdrawActivity.kt Show resolved Hide resolved
app/src/main/java/hous/release/android/presentation/withdraw/withdraw/WithdrawFragment.kt Show resolved Hide resolved
KWY0218
KWY0218 approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@KWY0218 KWY0218 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

구웃~! 👍

@2zerozu 2zerozu merged commit 4c683dd into develop Sep 25, 2023
1 check passed
@2zerozu 2zerozu deleted the feature/#292-ui-withdraw branch September 25, 2023 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@murjune murjune murjune approved these changes

@KWY0218 KWY0218 KWY0218 approved these changes

Assignees

@2zerozu 2zerozu

Labels
Pull Request🔥 풀리퀘 날림! refactor 내부 로직은 변경 하지 않고 기존의 코드를 개선하는 리팩토링 시 영주🐼 영주가 작업함!
Projects
None yet
Milestone
Hous 3차 릴리즈
Development

Successfully merging this pull request may close these issues.

[refactor] 탈퇴/피드백 뷰 분리
3 participants
@2zerozu @KWY0218 @murjune