Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request]: refactor gempyor model build / run to use ABC #433

Open
pearsonca opened this issue Jan 3, 2025 · 0 comments
Open

[Feature request]: refactor gempyor model build / run to use ABC #433

pearsonca opened this issue Jan 3, 2025 · 0 comments
Labels
enhancement Request for improvement or addition of new feature(s). gempyor Concerns the Python core. medium priority Medium priority.

Comments

@pearsonca
Copy link
Contributor

Label

dependency, enhancement, gempyor

Priority Label

medium priority

Is your feature request related to a problem? Please describe.

Shift associated with #432 - do this somewhat in parallel with #432, but should at least draft that first to represent "preferred" interface / boundary.

Is your feature request related to a new application, scenario round, pathogen? Please describe.

No response

Describe the solution you'd like

Refactor current simulate function to distinguish:

  • build step: should create and store a pickled object according to configuration specification.
  • run step: should receive parameters (not configuration file) and emit timeseries object (not store it)
  • separate out reading from / writing to do disk
  • separate out any "looping" constructs
@TimothyWillard TimothyWillard added enhancement Request for improvement or addition of new feature(s). gempyor Concerns the Python core. medium priority Medium priority. labels Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Request for improvement or addition of new feature(s). gempyor Concerns the Python core. medium priority Medium priority.
Projects
None yet
Development

No branches or pull requests

2 participants