Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hardcoded requirement for US-specific geoids in geodata file #23

Closed
alsnhll opened this issue Apr 11, 2023 · 1 comment
Closed

hardcoded requirement for US-specific geoids in geodata file #23

alsnhll opened this issue Apr 11, 2023 · 1 comment

Comments

@alsnhll
Copy link
Collaborator

alsnhll commented Apr 11, 2023

There are errors being caused by hard-coding that restricts us to simulating the US. For example inference_slot.R calls flepicommon:load_geodata_file to read the geodata file, but this function is expecting a column to be named “geoid” whereas you’re supposed to be able to name the column anything as long as its specified as nodename in the config. And in the section reading in ground truth data there is also some US specific stuff re fips codes, states etc. We don’t want anything US-specific outside of the get_ground_truth function.

@jcblemai
Copy link
Collaborator

Fixed in #62

@jcblemai jcblemai added this to the Paper resubmission milestone Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants