Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apache-pulsar 4.0.0 #198589

Merged
merged 2 commits into from
Nov 22, 2024
Merged

apache-pulsar 4.0.0 #198589

merged 2 commits into from
Nov 22, 2024

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Nov 22, 2024

Trying this again.

Partly split from #198490 but dependencies probably aren't needed.

@cho-m cho-m added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Nov 22, 2024
@github-actions github-actions bot added java Java use is a significant feature of the PR or issue no ARM bottle Formula has no ARM bottle long build Set a long timeout for formula testing labels Nov 22, 2024
@cho-m
Copy link
Member Author

cho-m commented Nov 22, 2024

Was trying to build a copy of https://github.com/grpc/grpc-java/tree/master/compiler and hack it into the build system for ARM.

So far not successful and hitting build failure:

A problem occurred configuring project ':grpc-gae-interop-testing-jdk8'.
> Could not create task ':grpc-gae-interop-testing-jdk8:animalsnifferMain'.
   > Could not create task of type 'AnimalSniffer'.
      > Could not generate a decorated class for type AnimalSniffer.
         > org/gradle/api/reporting/internal/TaskReportContainer

@Homebrew Homebrew deleted a comment from github-actions bot Nov 22, 2024
@cho-m cho-m marked this pull request as ready for review November 22, 2024 16:41
@cho-m
Copy link
Member Author

cho-m commented Nov 22, 2024

May try to fix ARM in follow up.

Need to first get a PR merged into protobuf to fix build on protoc-gen-grpc-java.

Problem afterward is hacking up Maven build to use system protoc. Right now, it is set up to fetch a pre-built copy of both protobuf and protoc-gen-grpc-java. Would probably need to patch the pom.xml files to avoid the artifacts https://github.com/apache/pulsar/blob/v4.0.0/pulsar-client/pom.xml#L265-L268:

          <protocArtifact>com.google.protobuf:protoc:${protoc3.version}:exe:${os.detected.classifier}</protocArtifact>
          <checkStaleness>true</checkStaleness>
          <pluginId>grpc-java</pluginId>
          <pluginArtifact>io.grpc:protoc-gen-grpc-java:${protoc-gen-grpc-java.version}:exe:${os.detected.classifier}

Or maybe manually run protoc depending on how checkStaleness works

@cho-m cho-m added the ready to merge PR can be merged once CI is green label Nov 22, 2024
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Nov 22, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Nov 22, 2024
Merged via the queue into master with commit a5f1b04 Nov 22, 2024
15 checks passed
@BrewTestBot BrewTestBot deleted the apache-pulsar-4.0.0 branch November 22, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. java Java use is a significant feature of the PR or issue long build Set a long timeout for formula testing no ARM bottle Formula has no ARM bottle ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants