-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
offest can't be higher than max integer value for viewing messages #10
Comments
Hey @doug2525 , we have some changes coming soon (this week hopefully) that change the internal data type of the offset field inside the MessageInspectorForm class to long, which should solve this. |
@michael-pratt That is great!! thanks for the quick response. |
@doug2525 We just pushed the latest version of code out on master, give it a try and let us know if it resolves your issue. |
@michael-pratt that seems to have corrected the issue. Thanks. Is there a list of updates for this version somewhere? |
@michael-pratt I found a bit of an issue with this new version. Any topics that have names that end in .json when you click them to get the topic details it shows json for the topic details. Other topic names seem fine. |
@doug2525 This is a spring artifact. By default it uses the URL to try and determine what content type to send back. With the .json extension on some of your topic URLs, Spring thinks you want JSON back, and we now have endpoints that provide that (previously there was only one mapping). Can you try adding this snippet in the Kafdrop.java and let me know if it helps?
|
@michael-pratt not much of a java developer so it could be me not doing something correctly but anywhere I add the snippet into the KafDrop.java maven can't resolve the objects. |
@doug2525 My guess is you were missing the import statements. You can try this branch if you want: https://github.com/HomeAdvisor/Kafdrop/tree/json_topic_fix I tested locally with a test topic that ended in .json and it appears to fix the problem. We'll try and work the permanent fix into an upcoming unit of work, but that branch should work in the meantime. |
@michael-pratt ya the import statements did the trick. The issue appears to be resolved with the snippet. Definitely let me know once you have the permanent fix in place and thanks. |
Get below error when trying to read messages "Failed to convert property value of type [java.lang.String] to required type [java.lang.Integer] for property offset; nested exception is java.lang.NumberFormatException: For input string: "5659373885" "
The text was updated successfully, but these errors were encountered: