Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edge Case: Previous Bottom Navigation Icon remains highlighted when using navigation drawer links #688

Open
philliplam8 opened this issue Feb 16, 2023 · 1 comment
Open

Edge Case: Previous Bottom Navigation Icon remains highlighted when using navigation drawer links #688

philliplam8 opened this issue Feb 16, 2023 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@philliplam8
Copy link
Contributor

philliplam8 commented Feb 16, 2023 •
edited
Loading

Very minor icon issue

Expected Behavior:

  • When the Bottom Navigation is revealed, only one icon should be highlighted (matching the active page)

Actual Behaviour:

  • The previous Bottom Navigation Icon remains highlighted when using navigation drawer links

Steps to reproduce:

  1. Visit https://holodex.net/
  2. Decrease browser width to <= 959px to reveal Bottom Navigation
  3. Open the top left navigation drawer/hamburger menu
  4. Click on Favorites
  5. Open the top left navigation drawer again
  6. Click on Home
  7. Notice in the Bottom Navigation, both Home and Favorites icons are highlighted
@philliplam8
Copy link
Contributor Author

Minor.Bug.-.Bottom.Nav.-.Active.Icon.Sync.mp4

@sphinxrave sphinxrave added bug Something isn't working good first issue Good for newcomers labels Apr 6, 2023
rsandz added a commit to rsandz/Holodex that referenced this issue May 14, 2023
@rsandz
Force bottom nav bar to refresh on route change
0128998 
Fixes icons staying highlighted in HolodexNet#688
@rsandz rsandz mentioned this issue May 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sphinxrave @philliplam8