Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create some endpoints #53

Open
vrom911 opened this issue May 9, 2019 · 4 comments
Open

Create some endpoints #53

vrom911 opened this issue May 9, 2019 · 4 comments
Labels
enhancement New feature or request

Comments

@vrom911
Copy link
Contributor

vrom911 commented May 9, 2019

To be able to run the application, add some tests to them

@vrom911 vrom911 added the enhancement New feature or request label May 9, 2019
@lucazulian
Copy link
Contributor

@vrom911 Can you give me some indications about that issue?

@vrom911
Copy link
Contributor Author

vrom911 commented May 22, 2019

We need to have the following endpoint to test:

  • One public endpoint
  • Login endpoint (which is already there, just need to structure better)
  • One protected endpoint

This issue is tight with #41 and would need to implement the separation of public and protected endpoints.

@lucazulian
Copy link
Contributor

Perfect, I wait for suggestion about #41 before this, thanks!

@chshersh
Copy link
Contributor

@lucazulian The idea here is to use generic capabilities of servant to impose structure on our endpoints. The root of all endpoints should be split into two parts: protected and unprotected. Endpoints under the protected namespace should use JWT-based auth scheme using experimental auth module from the servant library (we are not using servant-auth), so each incoming request is verified automatically. Unprotected endpoints shouldn't require this authentication because they either public or the produce this JWT token.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants