Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extinguisher is terrible for putting out fires #3292

Open
JohnGinnane opened this issue Jan 5, 2017 · 14 comments
Open

Extinguisher is terrible for putting out fires #3292

JohnGinnane opened this issue Jan 5, 2017 · 14 comments

Comments

@JohnGinnane
Copy link
Member

Terrible for turfs on fire, and even more for players on fire. Looking at the code I'm not even sure what reagent it's spewing when you use it. We should have another look at it and possibly have it send out actual water and make sure fire's can be put out with water

Code that makes me question what extinguishers use: https://github.com/HippieStationCode/HippieStation13/blob/56a3fdddeb58b6e0dedb20514f4cc43bee628c58/code/game/objects/items/weapons/extinguisher.dm#L146

@JohnGinnane
Copy link
Member Author

I think a common issue with using the fire extinguisher is when you put out tiles the fire is reignited because the temperature is still very high and/or the fuel is still there and/or nearby fire spreads. If you empty an extinguisher on one tile it (probably) shouldn't reignite right away

@JohnGinnane
Copy link
Member Author

It also looks like they're using water which is fine but that should result in slippy floors (if we're actually shooting water), and maybe possibly be dangerous to electronics

@JohnGinnane
Copy link
Member Author

Wait, seriously they do?

@JohnGinnane
Copy link
Member Author

What about those extinguishers that shoot out random colours? How are those done?

@JohnGinnane
Copy link
Member Author

JohnGinnane commented Jan 5, 2017

Oh, okay actually it starts full (50 units) with 9 parts water, 1 part cryo: https://github.com/HippieStationCode/HippieStation13/blob/56a3fdddeb58b6e0dedb20514f4cc43bee628c58/code/game/objects/items/weapons/extinguisher.dm#L41

I see these are transfer to a reagent (of size 5 I think) and 1 unit of reagent is transferred. This is very small for a fire extinguisher: https://github.com/HippieStationCode/HippieStation13/blob/56a3fdddeb58b6e0dedb20514f4cc43bee628c58/code/game/objects/items/weapons/extinguisher.dm#L151

@JohnGinnane
Copy link
Member Author

So buff extinguisher to hold WAY more than a large weaker and make it shoot out way more of the reagent. This should result in the tile being covered in water and the temperature of the turf being lowered significantly

@JohnGinnane
Copy link
Member Author

JohnGinnane commented Jan 5, 2017

Maybe don't fill extinguishers with water...

@KayeArray
Copy link
Contributor

They could just be filled entirely with cryogenic fluid as opposed to only 5u.

@JohnGinnane
Copy link
Member Author

Could be, but the amount is still so small I feel. The same capacity as a glass beaker with the output of a dropper

@KayeArray
Copy link
Contributor

The cryogenic fluid actually has a volume non dependent on turf reaction which sets gas temp to 0 and kills all hotspots so amount doesn't really matter (fire extinguishers used to be even worse at extinguishing fires) however changing the reagent amount should make it better at putting people out.

@JohnGinnane
Copy link
Member Author

Cool, ghetto cryo then? Does that change un temperature happen to players toi?

@Scinexx
Copy link
Contributor

Scinexx commented Jan 5, 2017

It does effect players sprayed

@KittyKathy
Copy link
Contributor

One thing to consider is that fire extinguishers spawn with 5 units out of the 50 being cryogenic fluid which is what the supposed buffed to them was so they were not shit at stopping fires.
What do you do when you use up everything in the fire extinguisher? You refill it at a water tank which contains no cryogenic fluid now you are back to having shitty fire extinguishers that are inferior to what it spawned as.
Maybe it should be able to automatically convert water to cryogenic fluid or something so refilling it is not a issue?
Also why is it so annoying to fill these things with whatever reagent you want, you have to find a water/welding tank empty it then fill it with whatever chemical you want then fill the extinguisher from the tank...why is this even a thing.

There was a time when extinguisher used to be able to wet floors...was not a good time try chasing people as sec. They would grab a extinguisher and run into maintenance spraying water all over the doorway and every tile the spray touched was wet. That may have been the main reason it was changed to need 10 units to wet the floor.

How about cryogenic fluid in extinguishers being able to freeze the floor slightly so it would be harder to catch on fire but not be slippery?

@JohnGinnane
Copy link
Member Author

Very good points, slipstinguisher would be chaos. Perhaps water should be more effective at cooling stuff

@github-staff github-staff deleted a comment May 9, 2024
@github-staff github-staff deleted a comment May 9, 2024
@github-staff github-staff deleted a comment May 9, 2024
@github-staff github-staff deleted a comment May 9, 2024
@github-staff github-staff deleted a comment May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants