Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add transaction.on_commit to send_email task #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add transaction.on_commit to send_email task #13

wants to merge 1 commit into from

Conversation

omerfarukabaci
Copy link
Contributor

@omerfarukabaci omerfarukabaci commented May 28, 2021 •
edited
Loading

Fixes: #12

This PR is conflicting with #7, we should add them both to the new version.

With this change, if there is a Django test that checks whether the email is sent or not, commit hooks should be run to send the email after the related part.

I don't know if there is a way to handle this without any breaking change.

@omerfarukabaci omerfarukabaci requested a review from alicertel May 28, 2021 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alicertel alicertel Awaiting requested review from alicertel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run email task after transaction is committed.
1 participant
@omerfarukabaci