Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable automatic locale [Feature] #510

Open
ChrisTVH opened this issue Jul 5, 2024 · 7 comments
Open

Disable automatic locale [Feature] #510

ChrisTVH opened this issue Jul 5, 2024 · 7 comments
Labels
proposed enhancement An enhancement/request that needs approval

Comments

@ChrisTVH
Copy link

ChrisTVH commented Jul 5, 2024

Proposed Feature Description:

I have noticed that when I log in too quickly after opening minecraft recently, the carbon chat messages appear in English, you could say it tries to detect the language of my client and as it can, it uses the default one.

However, I wouldn't want people logging in with the client in another language to see the messages in the default language, since I haven't customized it at all and since my network is geared towards one language only, then this feature doesn't do me much good.

Proposed Feature Functionality:

As the title says, offer in config.conf the possibility to disable language switching based on the client language.

@ChrisTVH ChrisTVH added the proposed enhancement An enhancement/request that needs approval label Jul 5, 2024
@NamiUni
Copy link
Contributor

NamiUni commented Jul 16, 2024

You can change the default settings to the locale that the user uses.
If the default locale is disabled, Carbon will be confused as to which locale to send a message in if it cannot detect the client's locale.

@ChrisTVH
Copy link
Author

You can change the default settings to the locale that the user uses. If the default locale is disabled, Carbon will be confused as to which locale to send a message in if it cannot detect the client's locale.

That's why I want an option that removes it to use the language I want, that's the purpose.

Of course anyone who has a multi language server will want to have this option active but for me it makes my server look bad for those who speak Spanish and see the messages in basic English because I haven't customized them.

@NamiUni
Copy link
Contributor

NamiUni commented Jul 16, 2024

English

Since neither of us are native English speakers, we might not be communicating our points effectively. lol
There might be some misunderstandings about the default settings and server specifications, so let me explain.

First, if a corresponding locale file exists in the locale folder of Carbon, messages will be sent according to the client's set locale. Therefore, it is generally unnecessary to change the default locale setting.

If the client's locale cannot be detected or if there is no matching locale in Carbon's locale folder, the default locale setting will be referred to. If it is set to es_ES, messages will be sent in Spanish even if the client's locale cannot be detected.

However, on servers like Paper or other Bukkit-based servers, if the player's language setting cannot be properly detected under certain conditions, such as right after the player joins, the player's locale will be temporarily set to en_US. If messages are being sent in English even though the default locale is not set to English, this might be the cause.

Would it be best if the issue of detecting the player's language could be fixed?

Spanish

Dado que ninguno de los dos somos hablantes nativos de inglés, es posible que no estemos comunicando nuestros puntos de manera efectiva. Podría haber algunos malentendidos sobre la configuración predeterminada y las especificaciones del servidor, así que permíteme explicar.

Primero, si existe un archivo de localización correspondiente en la carpeta de localización de Carbon, los mensajes se enviarán de acuerdo con la localización configurada del cliente. Por lo tanto, generalmente no es necesario cambiar la configuración de localización predeterminada.

Si no se puede detectar la localización del cliente o si no hay una localización coincidente en la carpeta de localización de Carbon, se hará referencia a la configuración de localización predeterminada. Si está configurada en es_ES, los mensajes se enviarán en español incluso si no se puede detectar la localización del cliente.

Sin embargo, en servidores como Paper u otros servidores basados en Bukkit, si la configuración de idioma del jugador no puede ser detectada correctamente bajo ciertas condiciones, como justo después de que el jugador se une, la localización del jugador se establecerá temporalmente en en_US. Si los mensajes se están enviando en inglés a pesar de que la localización predeterminada no está configurada en inglés, esta podría ser la causa.

¿Sería mejor si se pudiera solucionar el problema de la detección del idioma del jugador?

@ChrisTVH
Copy link
Author

Oh, so if you put it that way, then what I would have to do is just remove the other translation files so that I always use the one in Spanish.
The problem with detection sometimes happens in rare cases that it appears in English.

@NamiUni
Copy link
Contributor

NamiUni commented Jul 18, 2024

The other languages will be restored automatically if you delete them. If the problem is that the language changes to English, then changing the contents of messages-en_US.properties to Spanish is the solution that can be taken now.

@NamiUni
Copy link
Contributor

NamiUni commented Jul 18, 2024

It may be possible to stop sending messages until the client language can be detected.
So, I think we can leave the issue as it is.

@ChrisTVH
Copy link
Author

Okay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposed enhancement An enhancement/request that needs approval
Projects
None yet
Development

No branches or pull requests

2 participants