Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What about promises instead of callbacks? #17

Open
nilzen opened this issue Dec 15, 2013 · 8 comments
Open

What about promises instead of callbacks? #17

nilzen opened this issue Dec 15, 2013 · 8 comments

Comments

@nilzen
Copy link
Collaborator

nilzen commented Dec 15, 2013

Any thoughts @Hexagon @kmpm ? Can't think of an issue to have both though...

@Hexagon
Copy link
Owner

Hexagon commented Dec 15, 2013

As the promises is dropped in node (According to http://howtonode.org/promises) i would prefer the standard way. But if it doesn't cause any overhead (and someone find the time to implement it) I guess we could support both styles :)

@kmpm
Copy link
Collaborator

kmpm commented Dec 15, 2013

I like promises alot.... using https://github.com/kriskowal/q for example.
But perhaps later and definitely not replacing normal callbacks. I would be happy if we could get those sorted out first.
Promises is just adding some logic to the wrapper in it's simplest form.

@nilzen
Copy link
Collaborator Author

nilzen commented Dec 15, 2013

It feels like its trivial to add, I can look in to it later. Regarding that promises were dropped in Node 0.2, so would I have done with that syntax (attaching to events). The Q way of doing it with chainable code is much nicer!

@kmpm
Copy link
Collaborator

kmpm commented Dec 17, 2013

I would possibly move this to a later milestone and get node style callbacks stabilized first.

@Hexagon
Copy link
Owner

Hexagon commented Dec 17, 2013

Check :)

@nilzen
Copy link
Collaborator Author

nilzen commented Jan 7, 2014

I haven't got time to look in to this now, but more and more ppl are moving towards promises in node as well http://spion.github.io/posts/why-i-am-switching-to-promises.html

@kmpm
Copy link
Collaborator

kmpm commented Jan 8, 2014

It's no question about doing it or not, if you ask me.
It's a matter of time :)

@Hexagon Hexagon modified the milestones: 0.0.8, 0.0.9 Aug 28, 2014
@Hexagon Hexagon modified the milestones: 1.0.0, 0.0.9 Sep 16, 2014
@Hexagon Hexagon removed this from the 1.0.0 milestone Feb 2, 2016
@Hexagon
Copy link
Owner

Hexagon commented Feb 2, 2016

Removed milestone, it will be implemented when someone submit a pull request :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants