From a6e188b8d9d8824f7da188e1f793b0eec8d891e2 Mon Sep 17 00:00:00 2001 From: AnilKumar-NOAA Date: Mon, 13 Mar 2023 14:08:34 +0000 Subject: [PATCH 1/3] changes made in surface composite pre - remove use_flake section --- physics/GFS_surface_composites_pre.F90 | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/physics/GFS_surface_composites_pre.F90 b/physics/GFS_surface_composites_pre.F90 index a8b0a3112..131d26457 100644 --- a/physics/GFS_surface_composites_pre.F90 +++ b/physics/GFS_surface_composites_pre.F90 @@ -239,19 +239,19 @@ subroutine GFS_surface_composites_pre_run (im, lkm, frac_grid, enddo ! to prepare to separate lake from ocean under water category - do i = 1, im - if ((wet(i) .or. icy(i)) .and. lakefrac(i) > zero) then - lake(i) = .true. - if (lkm == 1 .and. lakefrac(i) >= 0.15 .and. lakedepth(i) > one) then - use_flake(i) = .true. - else - use_flake(i) = .false. - endif - else - lake(i) = .false. - use_flake(i) = .false. - endif - enddo +! do i = 1, im +! if ((wet(i) .or. icy(i)) .and. lakefrac(i) > zero) then +! lake(i) = .true. +! if (lkm == 1 .and. lakefrac(i) >= 0.15 .and. lakedepth(i) > one) then +! use_flake(i) = .true. +! else +! use_flake(i) = .false. +! endif +! else +! lake(i) = .false. +! use_flake(i) = .false. +! endif +! enddo ! if (frac_grid) then do i=1,im From c940cc2d2141006f40600fdb2a580f4b6ac42577 Mon Sep 17 00:00:00 2001 From: AnilKumar-NOAA Date: Mon, 13 Mar 2023 16:53:30 +0000 Subject: [PATCH 2/3] remove flake from scm_sfc_flux_spec.F90- RT test done --- physics/scm_sfc_flux_spec.F90 | 18 ++---------------- 1 file changed, 2 insertions(+), 16 deletions(-) diff --git a/physics/scm_sfc_flux_spec.F90 b/physics/scm_sfc_flux_spec.F90 index c55c3b72a..35ea03a99 100644 --- a/physics/scm_sfc_flux_spec.F90 +++ b/physics/scm_sfc_flux_spec.F90 @@ -52,7 +52,7 @@ end subroutine scm_sfc_flux_spec_init subroutine scm_sfc_flux_spec_run (im, u1, v1, z1, t1, q1, p1, roughness_length, spec_sh_flux, spec_lh_flux, & exner_inverse, T_surf, cp, grav, hvap, rd, fvirt, vonKarman, tgice, islmsk, dry, frland, cice, icy, tisfc,& oceanfrac, min_seaice, cplflx, cplice, flag_cice, wet, min_lakeice, tsfcl, tsfc_wat, slmsk, lakefrac, lkm,& - lakedepth, use_flake, sh_flux, lh_flux, sh_flux_chs, u_star, sfc_stress, cm, ch, & + lakedepth, sh_flux, lh_flux, sh_flux_chs, u_star, sfc_stress, cm, ch, & fm, fh, rb, u10m, v10m, wind1, qss, t2m, q2m, errmsg, errflg) use machine, only: kind_phys @@ -60,7 +60,7 @@ subroutine scm_sfc_flux_spec_run (im, u1, v1, z1, t1, q1, p1, roughness_length, integer, intent(in) :: im, lkm integer, intent(inout) :: islmsk(:) logical, intent(in) :: cplflx, cplice - logical, intent(inout) :: dry(:), icy(:), flag_cice(:), wet(:), use_flake(:) + logical, intent(inout) :: dry(:), icy(:), flag_cice(:), wet(:) real(kind=kind_phys), intent(in) :: cp, grav, hvap, rd, fvirt, vonKarman, min_seaice, tgice, min_lakeice real(kind=kind_phys), intent(in) :: u1(:), v1(:), z1(:), t1(:), q1(:), p1(:), roughness_length(:), & spec_sh_flux(:), spec_lh_flux(:), exner_inverse(:), T_surf(:), oceanfrac(:), lakefrac(:), lakedepth(:) @@ -207,20 +207,6 @@ subroutine scm_sfc_flux_spec_run (im, u1, v1, z1, t1, q1, p1, roughness_length, tisfc(i) = max(timin, min(tisfc(i), tgice)) end if end do - -! to prepare to separate lake from ocean under water category - do i = 1, im - if ((wet(i) .or. icy(i)) .and. lakefrac(i) > 0.0_kind_phys) then - if (lkm == 1 .and. lakefrac(i) >= 0.15 .and. lakedepth(i) > 1.0_kind_phys) then - use_flake(i) = .true. - else - use_flake(i) = .false. - endif - else - use_flake(i) = .false. - endif - enddo -! end subroutine scm_sfc_flux_spec_run From ad066d92274b60e6bbfc462f05fc89d9107f1be2 Mon Sep 17 00:00:00 2001 From: AnilKumar-NOAA Date: Wed, 15 Mar 2023 15:38:05 +0000 Subject: [PATCH 3/3] radiation surface remove use_flake if statement and srface composite pre --- physics/GFS_surface_composites_pre.F90 | 15 --------------- physics/radiation_surface.f | 4 ++-- 2 files changed, 2 insertions(+), 17 deletions(-) diff --git a/physics/GFS_surface_composites_pre.F90 b/physics/GFS_surface_composites_pre.F90 index 131d26457..209bbd424 100644 --- a/physics/GFS_surface_composites_pre.F90 +++ b/physics/GFS_surface_composites_pre.F90 @@ -238,21 +238,6 @@ subroutine GFS_surface_composites_pre_run (im, lkm, frac_grid, if (nint(slmsk(i)) /= 1) slmsk(i) = islmsk(i) enddo -! to prepare to separate lake from ocean under water category -! do i = 1, im -! if ((wet(i) .or. icy(i)) .and. lakefrac(i) > zero) then -! lake(i) = .true. -! if (lkm == 1 .and. lakefrac(i) >= 0.15 .and. lakedepth(i) > one) then -! use_flake(i) = .true. -! else -! use_flake(i) = .false. -! endif -! else -! lake(i) = .false. -! use_flake(i) = .false. -! endif -! enddo -! if (frac_grid) then do i=1,im if (dry(i)) then diff --git a/physics/radiation_surface.f b/physics/radiation_surface.f index 299f2e92c..e6cf93d5d 100644 --- a/physics/radiation_surface.f +++ b/physics/radiation_surface.f @@ -976,7 +976,7 @@ subroutine setemis & sfcemis_ice = semis_ice(i) ! output from CICE endif elseif (lsm == lsm_ruc) then - if (use_flake(i)) then +! if (use_flake(i)) then if (sncovr_ice(i) > f_zero) then sfcemis_ice = emsref(7) * (f_one-sncovr_ice(i)) & & + emsref(8) * sncovr_ice(i) @@ -990,7 +990,7 @@ subroutine setemis & semis_ice(i) = sfcemis_ice else sfcemis_ice = semis_ice(i) ! output from CICE or from RUC lsm (with snow effect) - endif +! endif endif ! lsm check endif ! icy