Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

networkAllow not tested on failing @condSend() variable writes #31

Open
trethaller opened this issue Oct 19, 2018 · 0 comments
Open

networkAllow not tested on failing @condSend() variable writes #31

trethaller opened this issue Oct 19, 2018 · 0 comments

Comments

@trethaller
Copy link
Member

Currently clients are allowed to modify vars marked as condSend(false) without any error:

		if( t.condSend.expr.match(EConst(CIdent("false"))) )
			return macro {}; // no marking
		var condSend = loop(t.condSend);
		needRef = true;
		mark = macro if( $condSend ) { this.$rname = this.$fname; $mark; };

We discussed removing the "no marking" optimization and adding a checkWrite() call in the else case so all failing condSend() are properly tested on clients.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant