-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Looking to understand missing data #44
Comments
This uses two new subgraphs to pull DAO memberships for Ethereum, xDai, and Polygon mainnets. The pulls are in parallel. The underlying data is structured the same way but seems to be missing some information, see HausDAO/daohaus-supergraph#44
Good catch! Dao titles are no longer saved in the subgraph. That was an old feature of moloch V1 and early V2 daos - added through registering in the factory. New factories for the latets v2 daos do not have that title field so we don't map anything to title. DAO titles can now be changed by daos - and it's stored in dao metadata outside the subgraph. I think the fix here is actually to remove the title field completely to avoid confusion. |
This uses two new subgraphs to pull DAO memberships for Ethereum, xDai, and Polygon mainnets. The pulls are in parallel. The underlying data is structured the same way but seems to be missing some information, see HausDAO/daohaus-supergraph#44
This uses two new subgraphs to pull DAO memberships for Ethereum, xDai, and Polygon mainnets. The pulls are in parallel. The underlying data is structured the same way but seems to be missing some information, see HausDAO/daohaus-supergraph#44
This uses two new subgraphs to pull DAO memberships for Ethereum, xDai, and Polygon mainnets. The pulls are in parallel. The underlying data is structured the same way but seems to be missing some information, see HausDAO/daohaus-supergraph#44
This uses two new subgraphs to pull DAO memberships for Ethereum, xDai, and Polygon mainnets. The pulls are in parallel. The underlying data is structured the same way but seems to be missing some information, see HausDAO/daohaus-supergraph#44
This uses two new subgraphs to pull DAO memberships for Ethereum, xDai, and Polygon mainnets. The pulls are in parallel. The underlying data is structured the same way but seems to be missing some information, see HausDAO/daohaus-supergraph#44
Hoping I can have someone validate my thinking on this one or give me pointers on where to look.
I'm looking at Moloch DAOs on xDai and Polygon and seeing some with no
members.moloch.title
. Here is an example query for a particular wallet:Running that query on the xDai subgraph page, these results come up (snipped for size, 12 of 14 results are
title: null
):On the xDai blockexplorer:
null
titleBoth seem to be Moloch based, which is good in that the subgraph is pulling the correct data based on my understanding.
My understanding
I have read through the Moloch.sol contract and the HausDao Summoner. I'm no Solidity expert but it seems that the only way to have a DAO title (with Moloch) is via the HausDao
registerDao
function which writes an event. With that understanding, would it be safe to assume that the DAOs in the results are Moloch based but were not registered? They may have been summoned or deployed by hand but probably not registered. Otherwise there would be a bug.Is my understanding correct? Is there a way I could verify or help to verify?
Related issue: MetaFam/TheGame#549
The text was updated successfully, but these errors were encountered: