Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Looking to understand missing data #44

Open
mattcan opened this issue May 24, 2021 · 1 comment
Open

Looking to understand missing data #44

mattcan opened this issue May 24, 2021 · 1 comment

Comments

@mattcan
Copy link

mattcan commented May 24, 2021

Hoping I can have someone validate my thinking on this one or give me pointers on where to look.

I'm looking at Moloch DAOs on xDai and Polygon and seeing some with no members.moloch.title. Here is an example query for a particular wallet:

{
  members(where: {memberAddress: "0xb53b0255895c4f9e3a185e484e5b674bccfbc076"}) {
    moloch { title }
    molochAddress
  }
}

Running that query on the xDai subgraph page, these results come up (snipped for size, 12 of 14 results are title: null):

{
  "data": {
    "members": [
      {
        "moloch": {
          "title": null
        },
        "molochAddress": "0x0079255ac5861e109fe80cd105fdc5de819897fa"
      },
      {
        "moloch": {
          "title": "HausDAO"
        },
        "molochAddress": "0x283bdc900b6ec9397abb721c5bbff5ace46e0f50"
      }
    ]
  }
}

On the xDai blockexplorer:

Both seem to be Moloch based, which is good in that the subgraph is pulling the correct data based on my understanding.

My understanding

I have read through the Moloch.sol contract and the HausDao Summoner. I'm no Solidity expert but it seems that the only way to have a DAO title (with Moloch) is via the HausDao registerDao function which writes an event. With that understanding, would it be safe to assume that the DAOs in the results are Moloch based but were not registered? They may have been summoned or deployed by hand but probably not registered. Otherwise there would be a bug.

Is my understanding correct? Is there a way I could verify or help to verify?

Related issue: MetaFam/TheGame#549

mattcan pushed a commit to MetaFam/TheGame that referenced this issue Jun 9, 2021
This uses two new subgraphs to pull DAO memberships for Ethereum, xDai,
and Polygon mainnets. The pulls are in parallel. The underlying data is
structured the same way but seems to be missing some information, see
HausDAO/daohaus-supergraph#44
@skuhlmann
Copy link
Contributor

Good catch!

Dao titles are no longer saved in the subgraph. That was an old feature of moloch V1 and early V2 daos - added through registering in the factory. New factories for the latets v2 daos do not have that title field so we don't map anything to title.

DAO titles can now be changed by daos - and it's stored in dao metadata outside the subgraph.

I think the fix here is actually to remove the title field completely to avoid confusion.

dan13ram pushed a commit to MetaFam/TheGame that referenced this issue Jun 13, 2021
This uses two new subgraphs to pull DAO memberships for Ethereum, xDai,
and Polygon mainnets. The pulls are in parallel. The underlying data is
structured the same way but seems to be missing some information, see
HausDAO/daohaus-supergraph#44
dan13ram pushed a commit to MetaFam/TheGame that referenced this issue Jun 13, 2021
This uses two new subgraphs to pull DAO memberships for Ethereum, xDai,
and Polygon mainnets. The pulls are in parallel. The underlying data is
structured the same way but seems to be missing some information, see
HausDAO/daohaus-supergraph#44
META-DREAMER pushed a commit to MetaFam/TheGame that referenced this issue Jun 14, 2021
This uses two new subgraphs to pull DAO memberships for Ethereum, xDai,
and Polygon mainnets. The pulls are in parallel. The underlying data is
structured the same way but seems to be missing some information, see
HausDAO/daohaus-supergraph#44
dan13ram pushed a commit to MetaFam/TheGame that referenced this issue Jun 14, 2021
This uses two new subgraphs to pull DAO memberships for Ethereum, xDai,
and Polygon mainnets. The pulls are in parallel. The underlying data is
structured the same way but seems to be missing some information, see
HausDAO/daohaus-supergraph#44
lucidcyborg pushed a commit to MetaFam/TheGame that referenced this issue Aug 6, 2021
This uses two new subgraphs to pull DAO memberships for Ethereum, xDai,
and Polygon mainnets. The pulls are in parallel. The underlying data is
structured the same way but seems to be missing some information, see
HausDAO/daohaus-supergraph#44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants