Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent propagation of voided vertices in on_new_tx() #1066

Open
glevco opened this issue Jun 13, 2024 · 2 comments
Open

Prevent propagation of voided vertices in on_new_tx() #1066

glevco opened this issue Jun 13, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@glevco
Copy link
Contributor

glevco commented Jun 13, 2024

          @msbrogli commented on https://github.com/HathorNetwork/hathor-core-side-dag/pull/11#discussion_r1634980005:

Nice rule. I guess we can add it to the on_new_tx() propagation part.

Originally posted by @glevco in #1061 (comment)

@jansegre
Copy link
Member

Is this specific to sync-v2? Either way we'd need a careful examination before doing this.

@jansegre jansegre added enhancement New feature or request and removed status/needs-review labels Oct 17, 2024
@glevco
Copy link
Contributor Author

glevco commented Oct 17, 2024

I don't think this is too relevant for now, specially since I'm refactoring multiple parts of the P2P and specifically this PR changes this. Maybe we can leave it on hold and review it again in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Todo
Development

No branches or pull requests

2 participants