-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build in Dockerfile #283
Comments
Will definitely look into this, thanks for sharing. |
Agreed, this is a common pattern these days and we'll definitely be moving towards it as we make our way through the v3 milestones. Do be aware though, using persistent Docker volumes to exclude subdirectories from the host's (project's) working directory will have the side effects of slowing the container's startup (after each image rebuild) and resulting in (potentially many) orphaned persistent volumes (of previous versions of I'd recommend the (admittedly more tedious) alternative of explicitly volume-mapping each individual project file and directory. If anyone has a better way, please share! |
Is there any reason why that we don't do the build in the Dockerfile so that it gets built on
docker-compose build
rather thandocker-compose up
? By being inup
, it effectively takes down your server every time you do a code push as there's a considerable wait for it to do the build inside the container. It also means that simple container restarts incur a build, even when you might not have pushed code.In my project, I have changed the Dockerfile to:
and added an additional volume map to
docker-compose.yml
to prevent volume-mapping the host's (blank) dist directory over top of what we've just built in the last step.Regardez:
Any reason for this? If not, I can do a PR as I think it's a much nicer workflow.
The text was updated successfully, but these errors were encountered: