Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in job processor: acq moved to "done" when error happens in pxCov or binMov. #8

Open
mjlm opened this issue Dec 15, 2014 · 0 comments
Labels

Comments

@mjlm
Copy link
Contributor

mjlm commented Dec 15, 2014

In the acquisition job processor, the function that moves around the acq file does not work as expected.

The acq is moved to the done folder even if an error happens during the pxCov or binMov calculation, because the acq-moving function is only triggered if the processCurrentAcq function exits (i.e. only for non-caught errors). It would be better to use the onCleanup object just for the user-abort case (Ctrl-C) and otherwise keep track if errors were caught. If there were errors, the acq file should be moved to the error folder, not to the done folder. The acq file should even be moved to error if Ctrl+C was pressed but a "real" error had happened previously during processing, so that the user is alerted to the fact that there was an error.

@mjlm mjlm added the bug label Dec 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant