Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree drops likely not consistent with vanilla behavior #4769

Open
garrettjoecox opened this issue Dec 28, 2024 · 1 comment
Open

Tree drops likely not consistent with vanilla behavior #4769

garrettjoecox opened this issue Dec 28, 2024 · 1 comment

Comments

@garrettjoecox
Copy link
Contributor

garrettjoecox commented Dec 28, 2024

I came across this while messing with tree bonking behavior in the holiday build, in #3171 an additional branch was added, leaving a hanging additional else condition, I'm honestly surprised it compiles and not really sure how it behaves in practice, but we should fix this, and maybe even VB-ify the behavior.

soh/src/overlays/actors/ovl_En_Wood02/z_en_wood02.c

if ((this->unk_14C >= 0) && (this->unk_14C < 0x64) && (CVarGetInteger("gTreeStickDrops", 0)) && !(INV_CONTENT(ITEM_STICK) == ITEM_NONE)) {
    ...
} else {
    ...
} else {
    ...
}
@serprex
Copy link
Contributor

serprex commented Dec 30, 2024

It compiles because the code is poorly indented, within the else there's an if that corresponds to last else

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants