Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mysterious Item model replacement shouldn't apply to the item overhead when you skip item animations #4718

Open
garrettjoecox opened this issue Dec 18, 2024 · 5 comments

Comments

@garrettjoecox
Copy link
Contributor

No description provided.

@Malkierian
Copy link
Contributor

To be honest, I'm not sure how it's applying to those to begin with...

@Malkierian
Copy link
Contributor

But if it's doing it how I'm starting to suspect, I don't know if there's a way to prevent that, because I don't think there's a way to get whether it's being shown in the world or as a get item.

@garrettjoecox
Copy link
Contributor Author

The item00 overhead should have the param ITEM00_SOH_GIVE_ITEM_ENTRY iirc, but tbh we proabably just need to migrate to my newer CustomCollectible pattern from 2ship, so maybe not worth fixing yet

@Malkierian
Copy link
Contributor

It does, and the custom draw function is already referencing that, but it doesn't have a rando check associated with it and I forget how to get it from that info.

@Archez
Copy link
Contributor

Archez commented Dec 18, 2024

Not sure if the new and improved custom handling deals with it already, but I did just add a flag in 2ship for tracking when an item00 is snapped to over player head specifically for interpolation handling https://github.com/HarbourMasters/2ship2harkinian/pull/894/files#diff-ef14e5f7a3b52ac88c6eb5f381e3cfc23a9e955a525ab3c95f86d26200120dbd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants