Beginning of separating out crates #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
tACK 32c9245
I've successfully joined MutinyNet federation, received (via Lightning), and paid (via Onchain).
It compiles and builds successfully when using the Nix environment, otherwise it fails locally due to sqlcipher library, however the same error occurs on master.
Comment on lines
22
to
+23
| reset-db: | ||
| diesel migration revert --all --database-url=harbor.sqlite && diesel migration run --database-url=harbor.sqlite | ||
| cd harbor-client && diesel migration revert --all --database-url=harbor.sqlite && diesel migration run --database-url=harbor.sqlite |
There was a problem hiding this comment.
@benthecarman I've been wondering about this command, is it right as the default used is ~/.harbor ?
There was a problem hiding this comment.
Yeah but looks like this was incorrect even before this pr. Will make an issue, good catch.
futurepaul
approved these changes
Nov 9, 2024
Comment on lines
22
to
+23
| reset-db: | ||
| diesel migration revert --all --database-url=harbor.sqlite && diesel migration run --database-url=harbor.sqlite | ||
| cd harbor-client && diesel migration revert --all --database-url=harbor.sqlite && diesel migration run --database-url=harbor.sqlite |
There was a problem hiding this comment.
Yeah but looks like this was incorrect even before this pr. Will make an issue, good catch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separates out backend logic to
harbor-clientand the UI toharbor-ui.For follow ups will clean up deps and try to make the the separation more clean