Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Welcome route #58

Merged
merged 2 commits into from
Jun 11, 2024
Merged

Welcome route #58

merged 2 commits into from
Jun 11, 2024

Conversation

TonyGiorgio
Copy link
Contributor

@TonyGiorgio TonyGiorgio commented May 21, 2024

TODO:

  • New wallet flow

Can do seed import in some follow up.

@TonyGiorgio TonyGiorgio force-pushed the welcome-route branch 2 times, most recently from f30309e to db22775 Compare June 5, 2024 02:18
@TonyGiorgio
Copy link
Contributor Author

Might need a little code cleanup but testing the new wallet / unlock wallet flow would be helpful. Let me know if there's anything we need to add or change.

Copy link
Contributor

@futurepaul futurepaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this works well for me, both for new wallet creation and working with an existing wallet. I think we should merge, it's a nice upgrade to what we have rn

@TonyGiorgio
Copy link
Contributor Author

I'll do a quick code review and clean up of a few things before I merge in and forget about it.

@TonyGiorgio TonyGiorgio force-pushed the welcome-route branch 2 times, most recently from 441d6ac to 6f17790 Compare June 11, 2024 20:56
@TonyGiorgio TonyGiorgio merged commit 14099c5 into master Jun 11, 2024
2 checks passed
@TonyGiorgio TonyGiorgio deleted the welcome-route branch June 11, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants