Put entire core processing into a thread #49
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought this would be a good idea to seperate the subscription thread stuff from core processing, but when I removed the thread spawn around the db unlock part, it did not actually fix the issue we had previously ran into. I think that's just because the thread it's in is still being bottlenecked, but it makes me question whether the whole subscription part is already in a thread anyways and I'm spinning up a new thread here unnecessarily.
I think making mpsc channel 50 is better anyways so I'll break that out into a new commit.
Was just thinking about threading earlier today and whether this would help, figured I'd get a second opinion and we can close it if it's pointless.
Thoughts?