Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put entire core processing into a thread #49

Closed
wants to merge 1 commit into from

Conversation

TonyGiorgio
Copy link
Contributor

I thought this would be a good idea to seperate the subscription thread stuff from core processing, but when I removed the thread spawn around the db unlock part, it did not actually fix the issue we had previously ran into. I think that's just because the thread it's in is still being bottlenecked, but it makes me question whether the whole subscription part is already in a thread anyways and I'm spinning up a new thread here unnecessarily.

I think making mpsc channel 50 is better anyways so I'll break that out into a new commit.

Was just thinking about threading earlier today and whether this would help, figured I'd get a second opinion and we can close it if it's pointless.

Thoughts?

@TonyGiorgio TonyGiorgio requested a review from benthecarman May 17, 2024 01:43
Copy link
Contributor

@benthecarman benthecarman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a good idea, just one small problem

src/core.rs Outdated Show resolved Hide resolved
@TonyGiorgio TonyGiorgio force-pushed the core-process-thread branch from 9508e4a to 7404357 Compare May 17, 2024 03:30
@benthecarman benthecarman deleted the core-process-thread branch May 17, 2024 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants