Send max on-chain #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
benthecarman
commented
May 16, 2024
benthecarman
commented
benthecarman
force-pushed
the
send-max-onchain
branch
from
8e1f08f to
7d54d24
Compare
futurepaul
requested changes
May 16, 2024
There was a problem hiding this comment.
I tried with a 0 balance. I have funds on-chain but they're not confirmed yet. (faucet couldn't find a route to me for 100k so that's why I did on-chain)
INFO harbor::core > Got UICoreMsg::SendOnChain
thread 'tokio-runtime-worker' panicked at /Users/futurepaul/.cargo/registry/src/index.crates.io-6f17d22bba15001f/fedimint-core-0.3.1/src/lib.rs:447:20:
attempt to subtract with overflow
benthecarman
force-pushed
the
send-max-onchain
branch
from
5f81a1d to
dbbca06
Compare
TonyGiorgio
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.