Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

donate screen and separate methods for on-chain / lighting send #19

Merged
merged 1 commit into from
May 15, 2024
Merged

donate screen and separate methods for on-chain / lighting send #19

merged 1 commit into from
May 15, 2024

Conversation

futurepaul
Copy link
Contributor

I didn't see #17 I need that kind of logic so I think I'll rebase to that? your call @benthecarman what's easier?

@futurepaul
Copy link
Contributor Author

Screenshot 2024-05-14 at 3 54 57 PM

@benthecarman
Copy link
Contributor

merged it so you can rebase

@futurepaul
Copy link
Contributor Author

rebased, donating on-chain to the faucet works!

benthecarman
benthecarman approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@benthecarman benthecarman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i successfully donated, we should make a really good success animation for this, that is also screenshotable/sharable well

@futurepaul futurepaul merged commit c49b68c into master May 15, 2024
2 checks passed
@futurepaul futurepaul deleted the donate-screen branch May 15, 2024 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benthecarman benthecarman benthecarman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@futurepaul @benthecarman