Skip to content
This repository has been archived by the owner on Nov 15, 2020. It is now read-only.

Detect if userAgent "not found" vs. zip archive not installed #43

Open
ThaDafinser opened this issue Jun 3, 2016 · 6 comments
Open

Comments

@ThaDafinser
Copy link
Contributor

When using this config

$config = [
            'username' => 'something',
            'secret' => 'something',

            'use_local' => true,

            'log_unknown' => false
        ];

And try to detect a userAgent, you may get Not found.

This can be a real "not found" or the filesdir is not correct.

A custom message for not correct installed or something like that would be good.

@elricho
Copy link
Member

elricho commented Jun 7, 2016

Great idea. We'll get that in the next minor update.

@ThaDafinser
Copy link
Contributor Author

Is this already possible? Just had the same issue again :-/

@elricho
Copy link
Member

elricho commented Dec 21, 2016

Hey @ThaDafinser : Sorry, fix installed (in 4.1.9).
It'll return a reply of status 299, with message 'Branch not found. Is it installed ?'

@ThaDafinser
Copy link
Contributor Author

@elricho thanks. it seems to be partly solved.

This case should fail
#53

@elricho
Copy link
Member

elricho commented Dec 21, 2016

@ThaDafinser : Awesome ! Thanks for the test case. I see what's happening here. The system is picking up that its a junk user-agent and returning status 301, message 'not found', without needing to go through the detection process and check that the files are (not) installed.

@elricho
Copy link
Member

elricho commented Dec 22, 2016

@ThaDafinser 4.1.10 solves the issue. Thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants