Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

semanticReleaseConfigDotnet#appendPlugins was broken by an async promise a long time ago #407

Open
BinToss opened this issue Jun 7, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@BinToss
Copy link
Member

BinToss commented Jun 7, 2024

OH! F***!

That's a Promise where a Promise's result should be!

Affects ^2.3.0 and all of next/3.0.0.

Blame 09d4202 feat(dotnet, node): convert static "Semantic Release Dotnet" to dynamic, exported config object

@BinToss BinToss added the bug Something isn't working label Jun 7, 2024
@BinToss BinToss self-assigned this Jun 7, 2024
@BinToss
Copy link
Member Author

BinToss commented Jun 10, 2024

steps to fix:

  • make a list of all Minor channels affected
  • make support branch for each minor version e.g. support/2.3.x
  • update semantic-release configuration in main and affected branches to allow releasing maintenance branches such as support/*.
  • remove async from affected functions and refactor to synchronous implementations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant